Fix inconsistent main icon detection, closes #496#497
Open
probonopd wants to merge 2 commits intoprobonopd:masterfrom
kefir500:fix-icon-detection
Open
Fix inconsistent main icon detection, closes #496#497probonopd wants to merge 2 commits intoprobonopd:masterfrom kefir500:fix-icon-detection
probonopd wants to merge 2 commits intoprobonopd:masterfrom
kefir500:fix-icon-detection
Conversation
Owner
Author
|
Oopsie, it looks like Travis is broken. "Some checks haven’t completed yet". Do we need to migrate all of this to GitHub Actions? |
Contributor
|
Oops, didn't notice that you have already created a pull request for my commit. Just in case, the updated commit from this PR is based on the latest changes in |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought the exisrting code would give preference to certain icon sizes, but it turns out it didn't.